[MRG] BF: Handle extension corrently in BIDSPath.match() #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't handle filename extensions properly, probably this bug was introduced when we moved `extension` out of `BIDSPath.entities` (cannot find the respective PR / commit now)
hoechenberger
changed the title
|
it fixes #539 ? |
Codecov Report
@@ Coverage Diff @@
## master #541 +/- ##
=======================================
Coverage 93.44% 93.45%
=======================================
Files 14 14
Lines 2076 2079 +3
=======================================
+ Hits 1940 1943 +3
Misses 136 136
Continue to review full report at Codecov.
|
|
thx @hoechenberger ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
We didn't handle filename extensions properly in
BIDSPath.match(); probably this bug was introduced when we movedextensionout ofBIDSPath.entities(cannot find the respective PR / commit now)Merge checklist
Maintainer, please confirm the following before merging: