Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More website fixes #9288

Merged
merged 11 commits into from
Apr 19, 2021
Merged

More website fixes #9288

merged 11 commits into from
Apr 19, 2021

Conversation

drammock
Copy link
Member

This PR:

  1. removes some cruft files that were no longer used (e.g., doc/_static/copybutton.js superseded by sphinx-copybutton dependency)
  2. refactors/simplfies our template files to take advantage of some new theme features
  3. updates the version switcher slightly to make it easier for touchscreens (rectangular hit area instead of just the text)
  4. tweaks the homepage gallery to address @larsoner's wish that the funders be more prominent (not offscreen at loadtime on a 1080p screen) --- this includes removing some excess whitespace in our main homepage logo SVG
  5. updates one institution logo
  6. tiny wording change on the funders page

marking as draft because there are some questions about the latest theme version causing big slowdowns with the rendering process (pydata/pydata-sphinx-theme#381), and I want to see how bad they are for us before moving forward.

@drammock drammock added the DOC label Apr 12, 2021
@drammock
Copy link
Member Author

Here is the updated homepage, for reference: https://27181-1301584-gh.circle-artifacts.com/0/dev/index.html

The size / alignment of the gallery images could use some tweaking. @larsoner feel free to push commits here if you want to experiment with getting the homepage the way you like it.

@agramfort
Copy link
Member

agramfort commented Apr 13, 2021 via email

@hoechenberger
Copy link
Member

hoechenberger commented Apr 13, 2021

Can we move the Quick start > button above the Funders?

@drammock
Copy link
Member Author

you have a glitch in the footer

fixed: https://27238-1301584-gh.circle-artifacts.com/0/dev/index.html

Can we move the Quick start > button above the Funders?

not easily, I'm afraid.

There is also now a second blocker (besides slower build time) that is keeping this as a draft PR: pydata/pydata-sphinx-theme#383

@cbrnr
Copy link
Contributor

cbrnr commented Apr 14, 2021

I mentioned this in #9289 but it belongs here: the TOC in the right column is broken, at least in https://27238-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/io/plot_20_reading_eeg_data.html - clicking on the various TOC entries highlights different sections.

@drammock
Copy link
Member Author

I mentioned this in #9289 but it belongs here: the TOC in the right column is broken

upstream issue: pydata/pydata-sphinx-theme#389

@jorisvandenbossche
Copy link
Contributor

It seems to be the sphinx-gallery css that conflicts with the theme's css. Removing the rule for .sphx-glr-example-title > :target::before, it seems to behave correctly.

@drammock
Copy link
Member Author

Thanks @jorisvandenbossche! I've followed up over at pydata/pydata-sphinx-theme#389

@drammock drammock mentioned this pull request Apr 18, 2021
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drammock I think the spacing bug should be fixed by a recent SG PR, feel free to merge if you're happy with this

@larsoner larsoner added this to the 0.23 milestone Apr 19, 2021
@drammock drammock marked this pull request as ready for review April 19, 2021 15:00
@drammock drammock merged commit f6d9c73 into mne-tools:main Apr 19, 2021
@drammock drammock deleted the more-web-fixes branch April 19, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants