Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fb profile url to ics description #100

Merged
merged 2 commits into from
May 15, 2021
Merged

Add fb profile url to ics description #100

merged 2 commits into from
May 15, 2021

Conversation

karbassi
Copy link
Contributor

No description provided.

@mobeigi mobeigi mentioned this pull request May 15, 2021
Closed
@mobeigi
Copy link
Owner

mobeigi commented May 15, 2021

Hi @karbassi ,

Thanks for the PR.

I made some small changes before merging including:

  • Using permalink in form of https://www.facebook.com/100000000 instead of a vanity URL https://www.facebook.com/my.name
  • Updating tests

Thank you!

@mobeigi mobeigi merged commit 7a93048 into mobeigi:master May 15, 2021
@karbassi karbassi deleted the add-profile-url branch May 16, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karbassi @mobeigi