Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #111: Fix token RegExp expression #112

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Fixes: #111: Fix token RegExp expression #112

merged 1 commit into from
Dec 25, 2023

Conversation

mobeigi
Copy link
Owner

@mobeigi mobeigi commented Dec 25, 2023

Context

  • Script has started to fail on JSON decoding of BirthdayCometMonthlyBirthdaysRefetchQuery response
  • This is because there are additional tokens on the page matching the existing simple regexp {\"token\":\"(.*?)\"'

Changes

  • Improve regexp to be more precise (to match desired token to use for fb_dtsg parameter)
  • Add improved error logging around JSON decoding issues (to allow us to fail early)

@mobeigi mobeigi merged commit a3c0b75 into master Dec 25, 2023
2 checks passed
@mobeigi mobeigi mentioned this pull request Dec 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mobeigi