Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to GraphQL api endpoint BirthdayCometRootQuery #81

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

mobeigi
Copy link
Owner

@mobeigi mobeigi commented Nov 12, 2020

Changes:

  • Use GraphQL BirthdayCometRootQuery endpoint
  • Remove old/now redudant code for the async endpoint
  • Update docs and requirements

Test changes by comparing previous and current ICS outputs:

  • Same number of events
  • Same data (except timestamp)
  • Really need tests!

@mobeigi mobeigi added this to the 1.2.0 milestone Nov 12, 2020
@mobeigi mobeigi merged commit f773c59 into master Nov 12, 2020
This was referenced Nov 12, 2020
@bonelifer
Copy link

Is the year included by default or is there a runtime flag needed?

@mobeigi
Copy link
Owner Author

mobeigi commented May 25, 2022

Is the year included by default or is there a runtime flag needed?

After your comment, I just checked for a first time in a long and it turns out Facebook have recently added the years into their API for us to use. I've updated the code to now include years (v1.2.4 supports it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants