Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial CRL logic to cert chain verification #71

Closed
wants to merge 1 commit into from
Closed

Add initial CRL logic to cert chain verification #71

wants to merge 1 commit into from

Conversation

nick-mobilecoin
Copy link
Collaborator

Motivation

This was referenced Apr 28, 2023
Merged
Merged
@github-actions github-actions bot added the size/L Large PRs label Apr 28, 2023
@meowblecoinbot meowblecoinbot requested a review from a team April 28, 2023 17:12
@nick-mobilecoin nick-mobilecoin mentioned this pull request Apr 28, 2023
Closed
@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Apr 28, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions
Copy link

❌ Unreviewed dependencies found

Crate Version Reviews (N/2) LoC Left-Pad Index Geiger Flags

@codecov
Copy link

codecov bot commented Apr 28, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (nick/chain@687cf04). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head ec9be0e differs from pull request most recent head 946aa56. Consider uploading reports for the commit 946aa56 to get more accurate results

@@              Coverage Diff              @@
##             nick/chain      #71   +/-   ##
=============================================
  Coverage              ?   96.99%           
=============================================
  Files                 ?        7           
  Lines                 ?     1665           
  Branches              ?        0           
=============================================
  Hits                  ?     1615           
  Misses                ?       50           
  Partials              ?        0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin nick-mobilecoin mentioned this pull request Apr 28, 2023
Open
11 tasks
nick-mobilecoin
nick-mobilecoin commented Apr 28, 2023
View reviewed changes
verifier/src/x509/chain.rs
if crl.issuer() == trust_anchor.subject_name() {
let verified_crl = crl.verify(&trust_anchor.public_key(), unix_time)?;
if verified_crl.is_cert_revoked(cert.serial_number()) {
return Err(Error::CertificateRevoked);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a bullet item to #50, we're going to need more robust test data the current CRL has no revoked cert also need to better list out what we're planning on supporting from https://www.rfc-editor.org/rfc/rfc5280

@nick-mobilecoin nick-mobilecoin mentioned this pull request May 1, 2023
Closed
This was referenced May 2, 2023
Closed
Closed
Closed
samdealy
samdealy approved these changes May 3, 2023
View reviewed changes
verifier/src/x509/chain.rs Show resolved Hide resolved
@nick-mobilecoin nick-mobilecoin requested a review from a team May 3, 2023 14:06
This was referenced May 5, 2023
Closed
Closed
@nick-mobilecoin nick-mobilecoin mentioned this pull request May 8, 2023
Closed
@nick-mobilecoin
Copy link
Collaborator Author

punting on implementing x509 chain parsing logic.

@nick-mobilecoin nick-mobilecoin deleted the nick/crl-in-cert-chain branch October 3, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdealy samdealy samdealy approved these changes

@jcape jcape Awaiting requested review from jcape

Assignees

@nick-mobilecoin nick-mobilecoin

Labels
size/L Large PRs
Projects
Core PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nick-mobilecoin @samdealy