Circuit oram/bit reverse #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b/mc-oblivious into CircuitOram/AddingLinearityTest
…c-oblivious into CircuitOram/RefactorPathOram
…c-oblivious into CircuitOram/RefactorPathOram
…tOram/RefactorPathOram
remoun
suggested changes
May 12, 2022
Co-authored-by: Remoun Metyas <remoun.metyas@gmail.com>
cbeck88
reviewed
May 13, 2022
| /// num_bits_needed. s.t. bit_reverse(0001, 3) returns 0100. | ||
| #[inline] | ||
| pub const fn bit_reverse(num: u64, num_bits_needed: u32) -> u64 { | ||
| // Build up the result in reversed by appending least significant bits and |
There was a problem hiding this comment.
Rust stabilized a bit reverse built-in function: rust-lang/rust#48763
It's probably much faster than this, do we actually need this function?
It seems like we could make this a one liner instead e.g. arg.reverse() >> (64-num_bits_needed)
There was a problem hiding this comment.
Oh neat. Didn't know about this. Let me look at it.
cbeck88
suggested changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a bit reverse utility function. This is useful for things like CircuitOram picking branches to evict.