-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI for SGX SDK action update #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-mobilecoin
force-pushed
the
update-sgx-sdk
branch
3 times, most recently
from
December 12, 2022 21:29
aebf136
to
28fc86e
Compare
jcape
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, but we should always use rust-toolchain@master
with a strategy matrix, because:
- I don't think there are tags for each nightly
- The
rust-toolchain
action doesn't change the default, so evenrust-toolchain@nightly
(which does exist) requires one to also docargo +nightly foo
at every invocation.
Also update the rust toolchain action to https://github.com/dtolnay/rust-toolchain
nick-mobilecoin
force-pushed
the
update-sgx-sdk
branch
from
December 12, 2022 21:31
28fc86e
to
c10d8d6
Compare
jcape
reviewed
Dec 12, 2022
The default rust/cargo in the GHA images is rust stable so there should be no need to specify the toolchain action unless a component is needed
awygle
approved these changes
Dec 14, 2022
This was referenced Dec 15, 2022
Merged
Merged
This was referenced Jan 10, 2023
Merged
Merged
This was referenced Jan 17, 2023
This was referenced Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update the rust toolchain action to https://github.com/dtolnay/rust-toolchain
Motivation
Future Work