Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI for SGX SDK action update #14

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Update CI for SGX SDK action update #14

merged 3 commits into from
Dec 14, 2022

Conversation

nick-mobilecoin
Copy link
Collaborator

Also update the rust toolchain action to https://github.com/dtolnay/rust-toolchain

Motivation

Future Work

@github-actions github-actions bot added the size/L Large PRs label Dec 12, 2022
@nick-mobilecoin nick-mobilecoin self-assigned this Dec 12, 2022
@nick-mobilecoin nick-mobilecoin force-pushed the update-sgx-sdk branch 3 times, most recently from aebf136 to 28fc86e Compare December 12, 2022 21:29
Copy link
Contributor

@jcape jcape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but we should always use rust-toolchain@master with a strategy matrix, because:

  1. I don't think there are tags for each nightly
  2. The rust-toolchain action doesn't change the default, so even rust-toolchain@nightly (which does exist) requires one to also do cargo +nightly foo at every invocation.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
The default rust/cargo in the GHA images is rust stable so there should
be no need to specify the toolchain action unless a component is needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Large PRs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants