-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Display
implementation for newtype wrappers
#301
Conversation
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
❌ Unreviewed dependencies found
|
Codecov Report
@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 88.27% 88.41% +0.13%
==========================================
Files 46 46
Lines 4154 4212 +58
==========================================
+ Hits 3667 3724 +57
- Misses 487 488 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Previously the new type implementations didn't implement the `Display` trait. Now the `Display` trait is implemented on any new type that uses one of `impl_newtype` or `impl_newtype_for_bytestruct`. Renamed the internal macro `new_type_accessors_impls` to `impl_newtype` for consistency.
9d75f2f
to
7b0489b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised the missing space before $wrapper
compiles...
Previously some `core::...` usages in macros lacked the leading `::` to indicate absolute crate paths. Now the usages are of the form `::core::...`. Made the hex output of wrapped C byte structs use an underscore every 2 bytes.
Display
implementation for new type wrappersDisplay
implementation for newtype wrappers
Previously the newtype implementations didn't implement the
Display
trait. Now the
Display
trait is implemented on any newtype that usesone of
impl_newtype
orimpl_newtype_for_bytestruct
.Renamed the internal macro
new_type_accessors_impls
toimpl_newtype
for consistency.