Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobfriend.py failing checks on Github Actions #133

Closed
deepfates opened this issue Feb 21, 2022 · 1 comment
Closed

mobfriend.py failing checks on Github Actions #133

deepfates opened this issue Feb 21, 2022 · 1 comment

Comments

@deepfates
Copy link
Contributor

When I push my branch to Github it fails checks due to a couple of #type: ignore checks in mypy:

Run pipenv run mypy sample_bots mc_util forest mobfriend contact imogen
  pipenv run mypy sample_bots mc_util forest mobfriend contact imogen
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.9.10/x64
mobfriend/mobfriend.py:[2](https://github.com/mobilecoinofficial/forest/runs/5281028606?check_suite_focus=true#step:8:2)22: error: Unused "type: ignore" comment
mobfriend/mobfriend.py:2[3](https://github.com/mobilecoinofficial/forest/runs/5281028606?check_suite_focus=true#step:8:3)[8](https://github.com/mobilecoinofficial/forest/runs/5281028606?check_suite_focus=true#step:8:8): error: Unused "type: ignore" comment
Found 2 errors in 1 file (checked 28 source files)
Error: Process completed with exit code 1.

When I run the same command locally it does not have this problem, though for some reason many other files fail?

╰─>$ pipenv run mypy sample_bots mc_util forest mobfriend contact imogen                                                                                                   (base) 
Courtesy Notice: Pipenv found itself running within a virtual environment, so it will automatically use that environment, instead of creating its own for any project. You can set PIPENV_IGNORE_VIRTUALENVS=1 to force pipenv to ignore that environment and create its own instead. You can set PIPENV_VERBOSITY=-1 to suppress this warning.
mc_util/printable_pb2.pyi:7: error: Library stubs not installed for "google.protobuf.descriptor" (or incompatible with Python 3.9)
mc_util/printable_pb2.pyi:7: error: Library stubs not installed for "google.protobuf" (or incompatible with Python 3.9)
mc_util/printable_pb2.pyi:8: error: Library stubs not installed for "google.protobuf.message" (or incompatible with Python 3.9)
mc_util/external_pb2.pyi:6: error: Library stubs not installed for "google.protobuf.descriptor" (or incompatible with Python 3.9)
mc_util/external_pb2.pyi:6: note: Hint: "python3 -m pip install types-protobuf"
mc_util/external_pb2.pyi:6: note: (or run "mypy --install-types" to install all missing stub packages)
mc_util/external_pb2.pyi:6: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
mc_util/external_pb2.pyi:6: error: Library stubs not installed for "google.protobuf" (or incompatible with Python 3.9)
mc_util/external_pb2.pyi:7: error: Library stubs not installed for "google.protobuf.internal.containers" (or incompatible with Python 3.9)
mc_util/external_pb2.pyi:7: error: Library stubs not installed for "google.protobuf.internal" (or incompatible with Python 3.9)
mc_util/external_pb2.pyi:8: error: Library stubs not installed for "google.protobuf.message" (or incompatible with Python 3.9)
forest/core.py:32: error: Library stubs not installed for "termcolor" (or incompatible with Python 3.9)
forest/core.py:32: note: Hint: "python3 -m pip install types-termcolor"
forest/core.py:48: error: Unused "type: ignore" comment
forest/core.py:643: error: Unused "type: ignore" comment
forest/core.py:644: error: Unused "type: ignore" comment
imogen/imogen.py:192: error: Unused "type: ignore" comment
imogen/imogen.py:206: error: Unused "type: ignore" comment
imogen/imogen.py:260: error: Item "MultipartReader" of "Union[MultipartReader, BodyPartReader]" has no attribute "name"
imogen/imogen.py:261: error: Item "MultipartReader" of "Union[MultipartReader, BodyPartReader]" has no attribute "filename"
imogen/imogen.py:268: error: Item "MultipartReader" of "Union[MultipartReader, BodyPartReader]" has no attribute "read_chunk"
mobfriend/mobfriend.py:19: error: Library stubs not installed for "google.protobuf" (or incompatible with Python 3.9)
Found 18 errors in 5 files (checked 28 source files)

I haven't edited mobfriend at all. I also see this happening in some other branches, specifically:
https://github.com/mobilecoinofficial/forest/runs/5238596966?check_suite_focus=true
https://github.com/mobilecoinofficial/forest/runs/5253050764?check_suite_focus=true
https://github.com/mobilecoinofficial/forest/runs/5262132498?check_suite_focus=true

My guess it might be local configuration environment configured differently from Github Actions?

@technillogue
Copy link
Contributor

wonder if this is related to prometheus/client_python#705 or hynek/prometheus-async#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants