Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check on branch prefix when not a subbranch #72

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

philippeauriach
Copy link
Member

@philippeauriach philippeauriach commented Sep 20, 2023

What does it do? Why?

https://app.asana.com/0/1200175269622723/1205540785118892/f

This action was throwing an error when a branch had the same prefix as another branch.

For example, if a branch named feature/test exists, then I am not able to create a branch named feature/test-2.
This PR removes this check.
The naming check will still be made when on a subpr (eg a pull request having another branch as its base).

@github-actions github-actions bot added the core Core Feature label Sep 20, 2023
Copy link
Member

@pierresisson pierresisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci 🙏🏻

@philippeauriach philippeauriach merged commit 941be0d into master Sep 20, 2023
@philippeauriach philippeauriach deleted the core/remove-same-prefix-branch-check branch September 20, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants