Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tsconfig with last tsconfig/base and node20 era #370

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Update tsconfig with last tsconfig/base and node20 era #370

merged 2 commits into from
Jul 13, 2023

Conversation

kachick
Copy link
Member

@kachick kachick commented Jul 13, 2023

Resolves #367

kachick
kachick commented Jul 13, 2023
View reviewed changes
src/Main.elm.d.ts
interface App {
ports: Ports;
}
declare module '*.elm' {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit d4a6785):

https://mobu-elm--pr370-update-tsconfig-ensmxqc4.web.app

(expires Thu, 20 Jul 2023 04:59:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c3bd1c7e660dfd047316b813d1455fa3121557d6

kachick
kachick commented Jul 13, 2023
View reviewed changes
vite.config.ts
@@ -1,5 +1,5 @@
import { defineConfig, loadEnv } from 'vite';
import elmPlugin from 'vite-plugin-elm';
import { plugin } from 'vite-plugin-elm';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Needed since "type": "module",

kachick
kachick commented Jul 13, 2023
View reviewed changes
tsconfig.json
"compilerOptions": {
"lib": ["ESNext", "DOM"],
"lib": ["dom", "dom.iterable"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kachick kachick merged commit 333fd44 into main Jul 13, 2023
@kachick kachick deleted the update-tsconfig branch July 13, 2023 05:02
@kachick kachick mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update tsconfig that is a missing task in updating to Node.js 20
1 participant
@kachick