Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

You have typo in defineProperty #540

Closed
Havunen opened this issue Aug 31, 2018 · 2 comments
Closed

You have typo in defineProperty #540

Havunen opened this issue Aug 31, 2018 · 2 comments

Comments

@Havunen
Copy link

Havunen commented Aug 31, 2018

Hi!

I was doing port of this awesome module to Inferno and noticed typo in your code. I though I could contribute it back to you :)

Its here:
https://github.com/mobxjs/mobx-react/blob/master/src/observer.js#L53

It should be writable
for reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty

😃

@Havunen
Copy link
Author

Havunen commented Aug 31, 2018

There is also another mistake here:
https://github.com/mobxjs/mobx-react/blob/master/src/observer.js#L49

which is missing .call(....)

@mweststrate
Copy link
Member

Thanks for noticing! Fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants