-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to get only the changed data in createViewModel #171
Comments
ItamarShDev
added a commit
to ItamarShDev/mobx-utils
that referenced
this issue
Feb 6, 2019
Looks like we need #173 if we want this to work correctly |
@apsavin why? these two seems unrelated really, am I missing something? |
ItamarShDev
added a commit
to ItamarShDev/mobx-utils
that referenced
this issue
Feb 20, 2019
I suppose that a programmer would expect that changedValues contains only values that differ from model. |
Oh, I see. |
ItamarShDev
added a commit
to ItamarShDev/mobx-utils
that referenced
this issue
Feb 20, 2019
Fixed issue mobxjs#171 Fixed issue mobxjs#173
@apsavin added fix to PR :) |
LGTM, thanks! |
fixed in #172 |
Released as 5.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, according to docs, createViewModel has only
isPropertyDirty(propName)
Is it possible to add an option to get all changed props (hopefully with the data)
looking at
mobx-utils/src/create-view-model.ts
Line 65 in c1d82ef
we can just open an option to get
localValues
back.The text was updated successfully, but these errors were encountered: