Allow action to handle async functions #2153
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps each "step" of an Async function in its own
action
. This removes the need forflow
, rewriting async functions as generators and most uses ofrunInAction
when used in the context of an async function.In the following example, the both
data
andloading
are run in a single action, removing the need for extrarunInAction
calls.Of course, this PR is simply a proof-of-concept and there's quite a few other things to consider:
runInAction
calls cause any issues?What do you think?
Instead of
you can simply write:
PR checklist:
/docs
. For new functionality, at leastAPI.md
should be updatednpm run perf
)