clear file mount stubs and fix empty layer cases #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
requested review from
sipsma and
coryb
and removed request for
sipsma
tonistiigi
force-pushed
the
empty-layer
branch
from
d7274cc to
1a21a78
Compare
AkihiroSuda
reviewed
Oct 19, 2020
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
empty-layer
branch
from
4544404 to
c8b8d6c
Compare
coryb
approved these changes
Oct 19, 2020
AkihiroSuda
approved these changes
Oct 20, 2020
|
could this patch be extended to also cover directory mounts? currently, when using we're left with an empty stub dir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes moby/moby#38667 by removing the empty files that were created for the mountpoints. Otherwise, paths used for secrets or
/etc/resolv.confwould remain in the image as empty files.While testing with the fix I discovered cases where empty layers were not handled properly for cache export. Extra commits fix these cases. After that, the example case in #1727 now produces reproducible digests.