Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: add tests for differ and pushed data #195

Merged
merged 2 commits into from
Dec 9, 2017
Merged

client: add tests for differ and pushed data #195

merged 2 commits into from
Dec 9, 2017

Conversation

tonistiigi
Copy link
Member

Working part of #191

@tonistiigi
integration: support local registry
e5771e2 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
client: add tests for differ and pushed data
f5f3b39 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi mentioned this pull request Dec 9, 2017
Merged
AkihiroSuda
AkihiroSuda approved these changes Dec 9, 2017
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Instead of pulling registry binary into the test container, we could use Docker Compose, but we can revisit it later.

@AkihiroSuda AkihiroSuda merged commit 8f8cf19 into moby:master Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonistiigi @AkihiroSuda