Allow none differ on local source to avoid false Dockerfile matches #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
force-pushed
the
local-differ-none
branch
from
dab2657 to
a552209
Compare
|
@tonistiigi needs a rebase |
|
@AkihiroSuda @crazy-max ptal |
|
(also would this one be ok to backport?) |
tonistiigi
force-pushed
the
local-differ-none
branch
from
a552209 to
31b38d1
Compare
tonistiigi
force-pushed
the
local-differ-none
branch
from
31b38d1 to
f9e9be0
Compare
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
local-differ-none
branch
from
f9e9be0 to
be61d26
Compare
coryb
approved these changes
Jun 29, 2021
This avoids wrong metadata matches on small files Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
local-differ-none
branch
from
be61d26 to
ee39f5d
Compare
coryb
approved these changes
Jul 1, 2021
AkihiroSuda
approved these changes
Jul 1, 2021
👆 any ideas on that? How risky is this change to backport? (too risky?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1368
Allows new
llb.Differproperty to configure what algorithm should be used when transferring file changes. Dockerfile frontend is updated to not trust metadata comparison for Dockerfile/dockerignore transfer. This can be extended in the future with some content-based comparison for better precision.