feat(run-mount): add support for variable expansion #2089
Merged
+199
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tonistiigi FYI |
tonistiigi
reviewed
Apr 26, 2021
There was a problem hiding this comment.
Missing DCO
I don't fully get the changes in convert.go. If it is just refactoring with no functional changes it should be in a different PR.
This doesn't fix the issues with output afaics. Fine by me if you want to tackle this in follow-up but should be fixed as well.
omermizr
force-pushed
the
feature/run-mount-variables
branch
from
4ca939e to
1f39eb8
Compare
|
Added DCOs. |
tonistiigi
reviewed
May 2, 2021
tonistiigi
reviewed
May 2, 2021
omermizr
force-pushed
the
feature/run-mount-variables
branch
from
590ab7d to
7dd7a67
Compare
tonistiigi
reviewed
May 4, 2021
Signed-off-by: Omer Mizrahi <ommizrah@microsoft.com>
omermizr
force-pushed
the
feature/run-mount-variables
branch
from
71c8bf4 to
1ac4230
Compare
tonistiigi
reviewed
May 5, 2021
tonistiigi
approved these changes
May 5, 2021
omermizr
force-pushed
the
feature/run-mount-variables
branch
from
1ac4230 to
aa46719
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for variable expansion in RUN mounts.
Resolves #815
Caveats:
fromexpansion is not supported.ONBUILD RUNcommands (I don't even think mounts work there).