Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile: fix git version detection #2208

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

tonistiigi
Copy link
Member

fix #2206

Looks like this broke in #2037 with migration from debian to alpine.

@coryb

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

@@ -12,6 +13,7 @@ FROM base AS version
ARG CHANNEL
# TODO: PKG should be inferred from go modules
RUN --mount=target=. \
set -e; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use && ?

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi force-pushed the dockerfile-version branch from f3802df to dc86c52 Compare June 29, 2021 05:06
@AkihiroSuda AkihiroSuda merged commit bb6f11c into moby:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dockerfile: git version check fails in ci
2 participants