[v0.9] cherry-picks #2386
Merged
[v0.9] cherry-picks #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 6735224)
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 5cfe388)
hosts mutex is called on initialization, meaning `GetResolver` might block if it is in the middle of auth exchange. This is currently bad in the case where Job initialization needs to register a name before timeout is reached. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 6bd2eb5)
Authorizer stores the current session.Group so if it is overwritten for another resolver it means that session might have been dropped and authentication will fail. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit f62bb55)
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 161b581)
|
You mentioned in this comment you may want a few commits from there also in the v0.9 branch: #2273 (comment) Doesn't matter to me either way, just mentioning in case leaving them out here was unintentional. |
Signed-off-by: Erik Sipsma <erik@sipsma.dev> (cherry picked from commit 808091a)
AkihiroSuda
approved these changes
Oct 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dockerfile: fix parsing required key without value #2304
control: fix 64bit alignment for buildcount #2324
resolver timeout fixes #2369
Fix flakiness during import of a cache with empty layers removed #2372