converter: make sure uncompressed digest annotation is set #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Oct 5, 2021
| @@ -191,7 +191,7 @@ func (c *conversion) convert(ctx context.Context, cs content.Store, desc ocispec | |||
| newDesc.MediaType = c.target.DefaultMediaType() | |||
| newDesc.Digest = info.Digest | |||
| newDesc.Size = info.Size | |||
| newDesc.Annotations = nil | |||
| newDesc.Annotations = map[string]string{labels.LabelUncompressed: diffID.Digest().String()} | |||
There was a problem hiding this comment.
if newDesc.Annotations == nil check in L201 can be now removed
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
ktock
force-pushed
the
converter-uncompressed-annotation
branch
from
ab8811f to
5c27a53
Compare
AkihiroSuda
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotation
"containerd.io/uncompressed"is required to be set for each blob descriptor and is used e.g. for creating image config.Make sure this is set to the converted blobs so that they will be handled correctly.