Add support for ulimit #2398
Merged
Add support for ulimit #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
ulimit
branch
2 times, most recently
from
9eb65e4 to
9caf612
Compare
12 tasks
|
(relates to moby/moby#40379) |
thaJeztah
reviewed
Oct 6, 2021
thaJeztah
reviewed
Oct 6, 2021
tonistiigi
reviewed
Oct 6, 2021
There was a problem hiding this comment.
Define a capability for this in https://github.com/moby/buildkit/blob/master/solver/pb/caps.go . The LLB logic should mark that the capability is needed. In dockerfile check for capability and don't call LLB if it isn't available. So if llb uses this with old daemon they get an error but if dockerfile does same it is ignored(we can log a warning) like before.
crazy-max
commented
Oct 7, 2021
crazy-max
force-pushed
the
ulimit
branch
2 times, most recently
from
3113309 to
6bc417e
Compare
thaJeztah
reviewed
Oct 7, 2021
tonistiigi
reviewed
Oct 7, 2021
crazy-max
force-pushed
the
ulimit
branch
2 times, most recently
from
dcb2de7 to
b9a86a6
Compare
tonistiigi
reviewed
Oct 8, 2021
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
tonistiigi
approved these changes
Oct 8, 2021
tonistiigi
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1665
Enable setting ulimit for exec commands similar to
docker build --ulimit.Signed-off-by: CrazyMax crazy-max@users.noreply.github.com