Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/containerd/containerd to v1.6.0-rc.2 #2608

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

crazy-max
Copy link
Member

Copy link
Collaborator

@ktock ktock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazy-max
Copy link
Member Author

crazy-max commented Feb 8, 2022

@thaJeztah Looking at containerd/containerd@bec6e4d I think I can remove the workaround at

// needs extra normalize for default spec
// https://github.com/moby/buildkit/pull/2427#issuecomment-952301867
expected := platforms.Normalize(platforms.DefaultSpec())

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but v1.6 GA is very soon

@crazy-max
Copy link
Member Author

LGTM but v1.6 GA is very soon

Ok I keep it in draft in the meantime

@crazy-max crazy-max marked this pull request as draft February 8, 2022 15:41
@tonistiigi
Copy link
Member

Part of this is also in #2588 that needs a rebase if not merged first.

@tonistiigi
Copy link
Member

Also, we have a somewhat unresolved issue with the previous vendor: #2589 (comment)

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@tonistiigi tonistiigi marked this pull request as ready for review February 14, 2022 22:24
@tonistiigi tonistiigi merged commit 1fbdce1 into moby:master Feb 14, 2022
@crazy-max crazy-max deleted the update-containerd branch February 14, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants