Eliminate auto-removal of empty layers #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vlad A. Ionescu <vladaionescu@users.noreply.github.com>
vladaionescu
force-pushed
the
vlad/fix-layer-index-upstream
branch
from
4823e58
to
d67243e
Compare
|
Should also fix #2551 Did you understand why it goes out of sync if the empty layer removal appears both on image and cache creation? |
Not really... I played around with some builds, but I couldn't really get to the bottom of it. |
|
Could you add a test that fails with previous behavior because of the wrong indexing? Or at least show a small reproducer for the issue. |
tonistiigi
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue related to inline caching resulting in cache import errors like this one:
invalid layer index 29. The cause of this is the image writer optimizing the final image by removing empty layers. Because this takes place after the inline cache manifest has been constructed, the indexes of the layers from the inline cache manifest end up being incorrect. Sometimes they end up being out of bounds.Originally reported as an issue in Earthly here: earthly/earthly#1635.
CC @tonistiigi
Signed-off-by: Vlad A. Ionescu vladaionescu@users.noreply.github.com