-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.11 backport] integration: enforce features compat through env vars #3713
[0.11 backport] integration: enforce features compat through env vars #3713
Conversation
|
@thaJeztah on
This has changed for v-next so now it will run the tests on moby: I'm still wondering why buildkit tests were failing with missing s3 backend as there is no integration tests for v0.11 🤔 cc @vvoland |
Would it make sense to backport the integration tests to improve coverage? |
Could we have a draft PR with CI run in moby to make sure this is all correct? |
IIRC it was this one: buildkit/client/client_test.go Line 4437 in 3f612f6
|
Oh good catch I missed this one. Will open a follow-up on BuildKit master branch to fix that. |
|
81a458a
to
5afe534
Compare
5afe534
to
f32de97
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> (cherry picked from commit 7f6cae2)
f32de97
to
cd49390
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> (cherry picked from commit 365598b)
cd49390
to
837e0e9
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> (cherry picked from commit f5aa841)
is this all up-to-date with #3715 ? |
@tonistiigi Yes |
backport of:
Not a clean cherry-pick.
testBasicS3CacheImportExport
,testBasicAzblobCacheImportExport
andtestBasicGhaCacheImportExport
are missing onv0.11
branch.