Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split vagrant provisioning #4147

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Aug 15, 2023

related to https://github.com/moby/buildkit/actions/runs/5862123682/job/15893429656#step:5:12

image

It should have failed at

go build -buildvcs=false .
but instead provisioning continue.

@crazy-max crazy-max force-pushed the refactor-vagrant branch 5 times, most recently from bf56c6d to 5145c16 Compare August 15, 2023 05:42
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max changed the title chore: split vagrant provisioning and use set and pipefail chore: split vagrant provisioning Aug 15, 2023
@crazy-max crazy-max marked this pull request as ready for review August 15, 2023 10:30
@crazy-max crazy-max merged commit 53f503b into moby:master Aug 16, 2023
55 checks passed
@crazy-max crazy-max deleted the refactor-vagrant branch August 16, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants