Update opencontainers/image-spec to v1.1.0-rc5 #4334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
reviewed
Oct 14, 2023
1 task
This brings in new string constants ImageIndexFile and ImagesBlobsDir. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
TBBle
force-pushed
the
random_small_fixes_broken_out_of_empty_cache_layer_work
branch
from
26d3ec8
to
f4d44fd
Compare
jedevc
approved these changes
Oct 17, 2023
|
Thanks @TBBle ❤️ |
TBBle
deleted the
random_small_fixes_broken_out_of_empty_cache_layer_work
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken out of #4331 since the actual change there may not be the right solution, and landing this lets me rebase that PR down to the essentials before possibly archiving it.
Changes per opencontainers/image-spec@v1.1.0-rc3...v1.1.0-rc5. None of the changes required corresponding changes in the BuildKit source.
I took the opportunity to replace a bunch of existing strings with newly-added constants from image-spec. (If this is a concern, it'd be trivial to drop or split into a different commit)
The original motivation for updating image-spec was to get access to
DescriptorEmptyJSON, which was renamed fromScratchDescriptorand had its media type changed. BuildKit had no existing users of this value, or the related media types.Also, some other small fixes in-passing:
Fix docs-upstream GitHub Action