docs: add a note that healthcheck --start-interval requires docker 25.0 #4382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdksn
reviewed
Oct 27, 2023
| @@ -2316,6 +2316,7 @@ However, if a health check succeeds during the start period, the container is co | |||
| started and all consecutive failures will be counted towards the maximum number of retries. | |||
|
|
|||
| **start interval** is the time between health checks during the start period. | |||
| This option will be first implemented in Docker 25.0. | |||
There was a problem hiding this comment.
Suggested change
| This option will be first implemented in Docker 25.0. | |
| This option requires Docker Engine version 25.0 or later. |
gwuah
added a commit
to superfly/flyctl
that referenced
this pull request
Nov 5, 2023
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
healthcheck-start-interval-note
branch
from
c206f7d
to
d064704
Compare
dvdksn
approved these changes
Nov 6, 2023
crazy-max
approved these changes
Nov 6, 2023
gwuah
added a commit
to superfly/flyctl
that referenced
this pull request
Nov 20, 2023
gwuah
added a commit
to superfly/flyctl
that referenced
this pull request
Dec 8, 2023
gwuah
added a commit
to superfly/flyctl
that referenced
this pull request
Dec 11, 2023
* init tracing in flyctl deploy path * downgrade buildkit moby/buildkit#4382 * instrument image resolving * export traces into jaegar for testing * authenticate all spans we send to honeycomb * better way to auth, i think * use dev & prod collectors accordingly * instrument all flaps calls * instrument all web calls * lowercase values and keys, remove tracing dependency * rip out duplicated tracing in flaps * attach user id to spana * linter wahala * use ctx to set request type * use snake case, address code review comments * pass original context * fix merge conflicts * attach trace context to http requests
benwaffle
pushed a commit
to benwaffle/fly-go
that referenced
this pull request
Apr 2, 2024
* init tracing in flyctl deploy path * downgrade buildkit moby/buildkit#4382 * instrument image resolving * export traces into jaegar for testing * authenticate all spans we send to honeycomb * better way to auth, i think * use dev & prod collectors accordingly * instrument all flaps calls * instrument all web calls * lowercase values and keys, remove tracing dependency * rip out duplicated tracing in flaps * attach user id to spana * linter wahala * use ctx to set request type * use snake case, address code review comments * pass original context * fix merge conflicts * attach trace context to http requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4355.