Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix formatting for warning callouts #4417

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

yumemio
Copy link
Contributor

@yumemio yumemio commented Nov 11, 2023

In the Dockerfile reference (1, 2, 3), the warning callouts were not rendered as intended, as shown in the picture below. Note the background color, the "i" icon and the trailing class attribute ({:.warning}):

The screenshot of an incorrectly rendered warning callout. The background color is blue, the title has "i" icon and there is a trailing class attribute

Here is how they should appear instead (content not relevant to the issue):

The screenshot of a correctly rendered warning callout. The background color is red, the title has "X" icon and there is no trailing directive

The PR updates the class attribute to match the Formatting Guide.

(Note: this is a redo of PR #4416, which I forgot to sign the commit)

Signed-off-by: yumemio <59369226+yumemio@users.noreply.github.com>
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

PTAL @dvdksn

Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tyvm

@jedevc jedevc merged commit f47104a into moby:master Nov 11, 2023
9 checks passed
@yumemio yumemio deleted the docs-fix-calling-callouts branch May 6, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants