On Dockerfiles, allow filepaths to be excluded from ADD and COPY commands #4440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It exposes the `ExcludePatterns` to the Dockerfile frontend, adding `--exclude=<pattern>` option in the COPY and ADD commands, which will cause filepaths matching such patterns not to be copied. `--exclude` can be used multiple times. Signed-off-by: Leandro Santiago <leandrosansilva@gmail.com>
Signed-off-by: Leandro Santiago <leandrosansilva@gmail.com>
leandrosansilva
force-pushed
the
feature/exclude-pattern-on-dockerfile
branch
from
3baf644
to
1078af8
Compare
|
I'm closing this for now. Not because we don't want it but because the design was not confirmed, and I don't want multiple places discussing this. Once there is some agreement in #4439, you can reopen. If you want to try things with CI then reopen as draft. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4439
This PR introduces new options in the Dockerfile frontend, namely
--excludeonCOPYandADDcommands.It essentially exposes the existing
ExcludePatternsfrom the LLB to the frontend.More information in the related issue #4439.
I did manage to only run the integration tests in the
frontenddirectory, which were the only parts changed, via, as all the other tests fail running to me, even when I am onmaster.I am open to suggestions on how to better test those changes, as I am not yet familiar with the codebase.