ci: update gha to account for node 16 deprecation #4605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
added
area/dependencies
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
thaJeztah
reviewed
Feb 1, 2024
| @@ -30,6 +28,6 @@ on: | |||
|
|
|||
| jobs: | |||
| validate: | |||
| uses: docker/docs/.github/workflows/validate-upstream.yml@main | |||
| uses: docker/docs/.github/workflows/validate-upstream.yml@919a9b9104a34a40b30d116529bcce589a544d1c # pin for artifact v4 support: https://github.com/docker/docs/pull/19220 | |||
There was a problem hiding this comment.
Is this because other branches / dependencies are not yet updated? (sorry perhaps silly question; trying to understand why main wouldn't work if both docs and this repository now support v4)
There was a problem hiding this comment.
This is to avoid having the workflow failing similar to docker/buildx#2210 (comment) in case artifact actions are bumped to v5 in the future on docs main and would/could therefore be incompatible with current v4.
There was a problem hiding this comment.
Ah, it's to pin to the current version (prevent updates); I was reading and thought it was downgrading the version 🤗
tonistiigi
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up
Update remaining GHA following the deprecation notice from GitHub: