llb: force platform in llb and allow constraints #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
force-pushed
the
llbconstraints
branch
from
2ae786b
to
defa9e9
Compare
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
llbconstraints
branch
from
defa9e9
to
4a8fdac
Compare
|
Marshal roundtrip tests added. Currently, only for platforms feature but same helpers can be used for more tests in the future. |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
llbconstraints
branch
from
4a8fdac
to
242697a
Compare
This was referenced Jun 23, 2018
AkihiroSuda
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces LLB definition to a specific platform to remove the ambiguity and allow workers to resolve correct images and validate worker constraints.
Constraints/platform can be defined per vertex or default can be set for the whole graph during marshal. If default platform is not set it is detected.
WIP: need to validate this actually works, add tests and fix examples to linux-amd64@tiborvass