Support creating and pushing OCI types #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebrow
reviewed
Jun 26, 2018
client/client_test.go
Outdated
| @@ -612,11 +611,15 @@ func testBuildPushAndValidate(t *testing.T, sb integration.Sandbox) { | |||
| dt, err = content.ReadBlob(ctx, img.ContentStore(), img.Target()) | |||
| require.NoError(t, err) | |||
|
|
|||
| var mfst schema2.Manifest | |||
| var msft = struct { | |||
dmcgowan
force-pushed
the
export-oci-media-types
branch
from
da6afec
to
0b3d80d
Compare
tonistiigi
reviewed
Jun 27, 2018
There was a problem hiding this comment.
Can we have the exporter opt called oci-mediatypes=true|false so it isn't confusing with the oci/docker exporter names. And also expose the opt to the oci/docker exporter because currently it still makes sense to use the oci layout but without the types(for example when working with containerd). The default can be based on the exporter name.
fyi @northtyphoon (#424)
exporter/containerimage/writer.go
Outdated
| @@ -41,7 +41,7 @@ type ImageWriter struct { | |||
| opt WriterOpt | |||
| } | |||
|
|
|||
| func (ic *ImageWriter) Commit(ctx context.Context, ref cache.ImmutableRef, config []byte) (*ocispec.Descriptor, error) { | |||
| func (ic *ImageWriter) Commit(ctx context.Context, ref cache.ImmutableRef, config []byte, OCI bool) (*ocispec.Descriptor, error) { | |||
There was a problem hiding this comment.
nit: don't capitalize oci here
dmcgowan
force-pushed
the
export-oci-media-types
branch
from
0b3d80d
to
8e5cc5f
Compare
|
Can we use https://github.com/containerd/containerd/blob/master/images/oci/exporter.go for pure OCI ? |
AkihiroSuda
approved these changes
Jun 27, 2018
dmcgowan
force-pushed
the
export-oci-media-types
branch
from
8e5cc5f
to
9c89633
Compare
Adds image and oci exporter option "oci-mediatypes" Ensures that the images created in the content store have the correct type which matches the manifest. Sets the correct media type on the descriptor in push from reading the type specified in the manifest. Removes use of distribution manifest packages. Signed-off-by: Derek McGowan <derek@mcgstyle.net>
dmcgowan
force-pushed
the
export-oci-media-types
branch
from
9c89633
to
618f34a
Compare
crazy-max
pushed a commit
to crazy-max/buildkit
that referenced
this pull request
Jun 8, 2022
Add docs for Dockerfile ADD/COPY --chown flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds image exporter option "oci".
Ensures that the images created in the content store have the correct type which matches the manifest.
Sets the correct media type on the descriptor in push from reading the type specified in the manifest.
Removes use of distribution manifest packages.
Needed for testing distribution/distribution#2076
A registry with that PR can be used with this change to push OCI manifests
Using