dockerfile: update args definitions to llb.EnvList #5349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids many temporary conversion between maps/slices and shell.EnvGetter. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
dockerfile-args
branch
from
2364a87
to
b9a4a6e
Compare
tonistiigi
commented
Sep 24, 2024
| @@ -2278,8 +2229,7 @@ func reportUnmatchedVariables(cmd instructions.Command, buildArgs []instructions | |||
| if len(unmatched) == 0 { | |||
| return | |||
| } | |||
| options := metaArgsKeys(opt.metaArgs) | |||
There was a problem hiding this comment.
@daghack I didn't replace this with globalArgs. Afaics the valid options need to be in the env . If they are defined in the global section but not available in the env then they can't be really used yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids many temporary conversion between maps/slices and shell.EnvGetter.