-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: frontend/dockerfile: update integration tests for windows/wcow #5382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than those comments, the rest LGTM.
May be just update your commit message too to match the PR, with the subject:
tests: frontend/dockerfile: update integration tests for windows/wcow
d8a972d
to
4c751c4
Compare
7a25fb0
to
ccdd43b
Compare
ccdd43b
to
a51f59d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While fixing the CI, can address the extra comment.
21872b8
to
340eceb
Compare
6048b78
to
f94db8d
Compare
- [x] `testCopyThroughSymlinkContext` - [x] `testIgnoreEntrypoint` - [x] `testQuotedMetaArgs` - [x] `testDockerfileCheckHostname` - [x] `testEmptyStages` - [x] `testNamedImageContextScratch` - [x] `testNamedImageContextPlatform` Signed-off-by: Daniel Githinji <danskigee@gmail.com>
f94db8d
to
3f9afc0
Compare
/cc. @tonistiigi PTAL. |
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Windows.
Partially addressing #4485
testCopyThroughSymlinkContext
testIgnoreEntrypoint
testQuotedMetaArgs
testDockerfileCheckHostname
testEmptyStages
testNamedImageContextScratch
testNamedImageContextPlatform