frontend: update lint checks to correctly utilize EnvList and EnvSetter #5387
+63
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daghack
changed the title
buildMetaArgs
daghack
force-pushed
the
nil-args-to-empty-strings
branch
12 times, most recently
from
aaaa54e
to
0cf9c64
Compare
daghack
force-pushed
the
nil-args-to-empty-strings
branch
5 times, most recently
from
4e79786
to
ca1798d
Compare
daghack
changed the title
daghack
force-pushed
the
nil-args-to-empty-strings
branch
from
ca1798d
to
ff4d22d
Compare
tonistiigi
reviewed
Oct 7, 2024
daghack
force-pushed
the
nil-args-to-empty-strings
branch
2 times, most recently
from
4d0fb89
to
496bf4f
Compare
tonistiigi
reviewed
Oct 8, 2024
tonistiigi
reviewed
Oct 8, 2024
after EnvGetter refactoring Signed-off-by: Talon Bowler <talon.bowler@docker.com>
daghack
force-pushed
the
nil-args-to-empty-strings
branch
from
496bf4f
to
161fc50
Compare
tonistiigi
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes regression from recent refactor around how we were passing around lists of environment variables and adds a test for this behavior.