contenthash: don't delete records when a directory is only modified #5521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, HandleChange would always recursively remove records whenever any Modify change was applied to a directory path. This was wasteful in the case where HandleChange was called only due to a metadata modification to a directory. In that case, it makes sense to *update* the directory's node but no existing entries under the directory need to be thrown away. Now, we only recursively remove records under a directory for the Delete case and when a Modify change replaces a directory with a non-directory. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
tonistiigi
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, HandleChange would always recursively remove records whenever any Modify change was applied to a directory path.
This was wasteful in the case where HandleChange was called only due to a metadata modification to a directory. In that case, it makes sense to update the directory's node but no existing entries under the directory need to be thrown away.
Now, we only recursively remove records under a directory for the Delete case and when a Modify change replaces a directory with a non-directory.