history: handle gracefulstop when history is active #5522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When GracefulStop is called gRPC waits for current requests to finish before closing. While this is generally the behavior we want, it is not always same for the History.Listen endpoint. That endpoint is usually open even if buildkit is not actively processing any builds, because client may be waiting for new events. The new logic is that if GracefulStop will happen, history will close active listeners if there are no active builds. If there are active builds then active listeners will be closed after all the active builds have completed their finalizers. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
history-gracefulstop-fix
branch
from
b241581 to
c45cd8f
Compare
crazy-max
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #5515When GracefulStop is called, gRPC waits for current requests to finish
before closing. While this is generally the behavior we want, it is
not always the same for the History.Listen endpoint. That endpoint is
usually open even if buildkit is not actively processing any builds,
because the client may be waiting for new events.
The new logic is that if GracefulStop happens, history will
close active listeners if there are no active builds. If there are
active builds, then active listeners will be closed after all the
active builds have completed their finalizers.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com