Set persist flag on the dummy network object during cleanup #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During sandboxcleanup operation, a dummy object is created if the kv-store is inaccessible during the daemon bootup. The dummy object is used for local processing of sandbox/endpoint cleanup operation. But unfortunately, since the persist flag was not set, the Skip() functionality kicked-in when sandbox was written back to the store and global endpoint was skipped to be tracked. During a subsequent cleanup operation, sandbox was removed and the global endpoint was left stale in the kv-store. The fix is to set the persist flag in the dummy object and that handles the sandbox and endpoint states appropriately and endpoint object is properly cleaned up when the KVStore becomes available. Signed-off-by: Madhu Venugopal <madhu@docker.com>
|
LGTM. Merge it yourself when CI is green. |
|
LGTM |
This was referenced May 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During sandboxcleanup operation, a dummy object is created if the
kv-store is inaccessible during the daemon bootup. The dummy object is
used for local processing of sandbox/endpoint cleanup operation. But
unfortunately, since the persist flag was not set, the Skip()
functionality kicked-in when sandbox was written back to the store and
global endpoint was skipped to be tracked. During a subsequent cleanup
operation, sandbox was removed and the global endpoint was left stale in
the kv-store.
The fix is to set the persist flag in the dummy object and that handles
the sandbox and endpoint states appropriately and endpoint object is
properly cleaned up when the KVStore becomes available.
Signed-off-by: Madhu Venugopal madhu@docker.com