Fix veth leak in overlay driver #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Because of the lazy logic in Leave(), the overlay veth end is not moved from the sandbox to the host network namspace until the last endpoint leaves. We cannot rely on this logic to clear the veth pairs, because on last endpoint leave we have no reference to the other N-1 veth names. - The fix is to delete the container veth end on endpoint delete. This anyways deletes both veth ends, regardless they are in different namespaces. Signed-off-by: Alessandro Boch <aboch@docker.com>
|
LGTM |
1 similar comment
|
LGTM |
mavenugo
added a commit
that referenced
this pull request
Mar 8, 2016
Fix veth leak in overlay driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
veth end is not moved from the sandbox to the host
network namspace until the last endpoint leaves.
We cannot rely on this logic to clear the veth pairs,
because on last endpoint leave we have no reference to
the other N-1 veth names.
This anyways deletes both veth ends, regardless they are in different
namespaces.
Note: I'd be happy to remove the code at https://github.com/docker/libnetwork/blob/master/drivers/overlay/ov_network.go#L173[That cannot be removed as it was not intended to handle the veth pairs that connect to the container sandbox]as it is no longer needed.
Fixes #984
Signed-off-by: Alessandro Boch aboch@docker.com