Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: update go versions #90

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Dec 19, 2022

Looks like CI was no longer working, because ltag now required a newer version of go;

pushd $(mktemp -d) \
  && go get -u github.com/kunalkushwaha/ltag \
  && popd \
  && ./scripts/validate/fileheader
  shell: /usr/bin/bash -e {0}
  env:
    GOROOT: /opt/hostedtoolcache/go/1.13.15/x64
/tmp/tmp.wrQsimdF1t ~/work/spdystream/spdystream
# github.com/kunalkushwaha/ltag
Error: /home/runner/go/src/github.com/kunalkushwaha/ltag/bash.go:25:15: undefined: os.ReadFile
Error: /home/runner/go/src/github.com/kunalkushwaha/ltag/dockerfile.go:23:15: undefined: os.ReadFile
Error: /home/runner/go/src/github.com/kunalkushwaha/ltag/golang.go:23:15: undefined: os.ReadFile
Error: /home/runner/go/src/github.com/kunalkushwaha/ltag/makefile.go:15:15: undefined: os.ReadFile
Error: Process completed with exit code 2.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@dims PTAL

Copy link
Collaborator

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

Thx! Let me get this one in, and rebase the other one 👍

@thaJeztah thaJeztah merged commit 57d1ca2 into moby:master Dec 19, 2022
@thaJeztah thaJeztah deleted the update_go_versions branch December 19, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants