updater: Change tests not to set StopGracePeriod #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updater used to use StopGracePeriod to figure out how long to wait for stopping a task to timeout. In 47ddece, this was changed to use an updater-level parameter instead. So there is no reason for tests to set StopGracePeriod or refer to it. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Current coverage is 55.01% (diff: 100%)@@ master #1745 diff @@
==========================================
Files 101 101
Lines 16500 16500
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 9103 9078 -25
- Misses 6262 6288 +26
+ Partials 1135 1134 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updater used to use StopGracePeriod to figure out how long to wait for stopping a task to timeout. In 47ddece, this was changed to use an updater-level parameter instead. So there is no reason for tests to set StopGracePeriod or refer to it.