agent: Correct fix for pre-LogBroker managers #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that no error is returned until we actually try to receive from the stream. Move the check to the right place. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
|
LGTM |
Current coverage is 55.14% (diff: 0.00%)@@ master #1784 diff @@
==========================================
Files 102 102
Lines 16876 16876
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 9288 9307 +19
+ Misses 6431 6413 -18
+ Partials 1157 1156 -1
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that no error is returned until we actually try to receive
from the stream. Move the check to the right place.