-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increased wait time on test utils WaitForCluster and WatchTaskCreate #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olljanat
force-pushed
the
fix-waitforcluster-test
branch
from
October 10, 2018 16:11
ac348f2
to
9b5c11d
Compare
olljanat
changed the title
Increased wait time on WaitForCluster testutils
WIP: Increased wait time on WaitForCluster testutils
Oct 10, 2018
olljanat
force-pushed
the
fix-waitforcluster-test
branch
4 times, most recently
from
October 10, 2018 19:01
15b0b09
to
7e7ccf7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2762 +/- ##
=========================================
Coverage ? 61.81%
=========================================
Files ? 134
Lines ? 21857
Branches ? 0
=========================================
Hits ? 13510
Misses ? 6886
Partials ? 1461 |
olljanat
changed the title
WIP: Increased wait time on WaitForCluster testutils
Increased wait time on WaitForCluster testutils
Oct 10, 2018
@cyli FYI |
olljanat
force-pushed
the
fix-waitforcluster-test
branch
from
October 11, 2018 19:55
7e7ccf7
to
00dae50
Compare
olljanat
changed the title
Increased wait time on WaitForCluster testutils
Increased wait time on test utils WaitForCluster and WatchTaskCreate
Oct 11, 2018
olljanat
force-pushed
the
fix-waitforcluster-test
branch
from
October 11, 2018 20:03
00dae50
to
8e7aa1b
Compare
Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
olljanat
force-pushed
the
fix-waitforcluster-test
branch
from
October 11, 2018 20:21
8e7aa1b
to
5f167ca
Compare
wk8
approved these changes
Oct 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
anshulpundir
approved these changes
Oct 11, 2018
Looks that CI test from master have been failed to error
which is fixed on this PR. @dperny time to merge? |
This was referenced Oct 18, 2018
This was referenced Sep 25, 2019
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Oct 9, 2019
…v18.09) full diff: moby/swarmkit@142a737...5c86095 - moby/swarmkit#2892 [18.09 backport] Remove hardcoded IPAM config subnet value for ingress network - backport of moby/swarmkit#2890 Remove hardcoded IPAM config subnet value for ingress network - fixes [ENGORC-2651](https://docker.atlassian.net/browse/ENGORC-2651) - moby/swarmkit#2836 [18.09 backport] Switch to go 1.11 - backport of moby/swarmkit#2752 Switch to go 1.11 - moby/swarmkit#2901 [18.09 backport] Bump to golang 1.12.9 - backport of moby/swarmkit#2880 Bump to golang 1.12.9 - moby/swarmkit#2900 [18.09 backport] Fix update out of sequence and increase max recv gRPC message size for nodes and secrets - backport of moby/swarmkit#2762 Increased wait time on test utils WaitForCluster and WatchTaskCreate - backport of moby/swarmkit#2771 Allow using Configs as CredentialSpecs - **second commit only** (attempt to fix weirdly broken tests) - backport of moby/swarmkit#2808 Fix flaky tests - backport of moby/swarmkit#2866 Swap gometalinter for golangci-lint - backport of moby/swarmkit#2869 Increase max recv gRPC message size to initialize connection broker - related / similar to moby#38103 / docker-archive#102 cluster: set bigger grpc limit for array requests - related / similar to moby#39306 Increase max recv gRPC message size for nodes and secrets - fixes moby/swarmkit#2733 Error generated when messages size is too big - backport of moby/swarmkit#2870 Fix update out of sequence Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Oct 23, 2019
…v18.09) full diff: moby/swarmkit@142a737...5c86095 - moby/swarmkit#2892 [18.09 backport] Remove hardcoded IPAM config subnet value for ingress network - backport of moby/swarmkit#2890 Remove hardcoded IPAM config subnet value for ingress network - fixes [ENGORC-2651](https://docker.atlassian.net/browse/ENGORC-2651) - moby/swarmkit#2836 [18.09 backport] Switch to go 1.11 - backport of moby/swarmkit#2752 Switch to go 1.11 - moby/swarmkit#2901 [18.09 backport] Bump to golang 1.12.9 - backport of moby/swarmkit#2880 Bump to golang 1.12.9 - moby/swarmkit#2900 [18.09 backport] Fix update out of sequence and increase max recv gRPC message size for nodes and secrets - backport of moby/swarmkit#2762 Increased wait time on test utils WaitForCluster and WatchTaskCreate - backport of moby/swarmkit#2771 Allow using Configs as CredentialSpecs - **second commit only** (attempt to fix weirdly broken tests) - backport of moby/swarmkit#2808 Fix flaky tests - backport of moby/swarmkit#2866 Swap gometalinter for golangci-lint - backport of moby/swarmkit#2869 Increase max recv gRPC message size to initialize connection broker - related / similar to moby/moby#38103 / docker-archive/engine#102 cluster: set bigger grpc limit for array requests - related / similar to moby/moby#39306 Increase max recv gRPC message size for nodes and secrets - fixes moby/swarmkit#2733 Error generated when messages size is too big - backport of moby/swarmkit#2870 Fix update out of sequence Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: e06f07ef337ab890f211397d6b408b75a2512dc5 Component: engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find out that most of the flaky tests looks to be caused by timeout during slowness on test machine.
This theory can be proven by running tests with CPU limit. I used these commands on my four core machine:
- What I did
Fixes flaky tests on #2559 , #2600 and #2661