Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests #2808

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Fix flaky tests #2808

merged 1 commit into from
Jun 20, 2019

Commits on Jun 20, 2019

  1. Fix flaky tests

    It is likely that a large portion of test flakiness, especially in CI,
    comes from the fact that swarmkit components under test are started in
    goroutines, but those goroutines never have an opportunity to run. This
    adds code ensuring those goroutines are scheduled and run, which should
    hopefully solve many inexplicably flaky tests.
    
    Additionally, increased test timeouts, to hopefully cover a few more
    flaky cases.
    
    Finally, removed direct use of the atomic package, in favor of less
    efficient but higher-level mutexes.
    
    Signed-off-by: Drew Erny <drew.erny@docker.com>
    dperny committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    06a3566 View commit details
    Browse the repository at this point in the history