Skip to content

Commit

Permalink
Eagerly set process.exitCode (#2820)
Browse files Browse the repository at this point in the history
To workaround process being terminated earlier than expected.

Simpler version of PR #2714 which only eagerly sets the exitcode without playing with the draining semantics.
  • Loading branch information
chrisleck authored and dasilvacontin committed May 24, 2017
1 parent fc35691 commit 10ff0ec
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion bin/_mocha
Original file line number Diff line number Diff line change
Expand Up @@ -476,12 +476,18 @@ function exitLater (code) {
}

function exit (code) {
var clampedCode = Math.min(code, 255);

// Eagerly set the process's exit code in case stream.write doesn't
// execute its callback before the process terminates.
process.exitCode = clampedCode;

// flush output for Node.js Windows pipe bug
// https://github.com/joyent/node/issues/6247 is just one bug example
// https://github.com/visionmedia/mocha/issues/333 has a good discussion
function done () {
if (!(draining--)) {
process.exit(Math.min(code, 255));
process.exit(clampedCode);
}
}

Expand Down

0 comments on commit 10ff0ec

Please sign in to comment.