Replace type() -> typeof

Add truthy check to handle null edge case type(ES Module) => "module", but we treat it the same as an object
mochajs · May 28, 2020 · c411c30 · c411c30
1 parent ebc2a07
commit c411c30
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/cli/run-helpers.js b/lib/cli/run-helpers.js
@@ -93,7 +93,8 @@ exports.handleRequires = async (requires = []) => {
     }
     const requiredModule = await requireOrImport(modpath);
     if (
-      ['object', 'module'].includes(type(requiredModule)) &&
+      requiredModule &&
+      typeof requiredModule === 'object' &&
       requiredModule.mochaHooks
     ) {
       const mochaHooksType = type(requiredModule.mochaHooks);

diff --git a/test/integration/fixtures/esm/require.mjs b/test/integration/fixtures/esm/require.mjs