Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncaught exceptions' stack traces aren't being printed #1199

Closed
jonathanong opened this issue Apr 24, 2014 · 10 comments
Closed

uncaught exceptions' stack traces aren't being printed #1199

jonathanong opened this issue Apr 24, 2014 · 10 comments

Comments

@jonathanong
Copy link
Contributor

screen shot 2014-04-23 at 6 58 06 pm

super annoying to debug =/

@dougwilson
Copy link
Contributor

yep

@boneskull
Copy link
Contributor

@jonathanong Do we know what caused this?

@jonathanong
Copy link
Contributor Author

if i knew i would fix it!

@travisjeffery
Copy link
Contributor

is this related to this #1198 ? may be fixed in the latest version.

@boneskull
Copy link
Contributor

@travisjeffery Doesn't appear to be. I reverted the change and am still not getting a full stack.

@boneskull
Copy link
Contributor

OK, this has been an issue for a long time. I checked as early as v1.10.0 and it's still there. This seems to only affect the "maximum call stack size exceeded" RangeError; other uncaught errors still give a proper trace.

So if I had to hazard a guess, NodeJS could do a better job of telling the user exactly where the recursive error happened.

I'm not sure there's anything to do here.

@travisjeffery
Copy link
Contributor

👍 for node handling this better

@boneskull
Copy link
Contributor

@travisjeffery To test the plain ol' uncaught exceptions, I followed the directions in uncaught.js and observed the results.

To test maximum call stack size exceeded, I appended this test to the same file:

  it('should give you a proper stack trace if recursive error', function (done) {
    process.nextTick(function notDone() {
      notDone();
    })
  });

I found this SO thread and I'm thinking we're SOL here.

@boneskull
Copy link
Contributor

(fwiw I tried this under NodeJS v0.11.13 and it still doesn't work)

@travisjeffery
Copy link
Contributor

alright we might as well close this here i guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants