Fix TypeError when generating diff for an object with circular structure #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm good with this. If anyone disagrees, please pipe up. |
|
My only fear is this might break something - but if it's tested properly I'm absolutely 👍 with this |
|
Well it's just the diff output so I'm not sure what it could break further than it's broken already. @skozin Could you provide a test for this please? |
|
ya if we get a test for this then it's g2g |
|
@travisjeffery thanks |
tandrewnichols
pushed a commit
to tandrewnichols/mocha
that referenced
this pull request
Dec 15, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1179